Skip to content

Upgrade Babel runtime for optional chaining support - #4

Open
evghenimelnic wants to merge 1 commit into
mainfrom
codex/create-online-chat-system-2hmenm
Open

Upgrade Babel runtime for optional chaining support#4
evghenimelnic wants to merge 1 commit into
mainfrom
codex/create-online-chat-system-2hmenm

Conversation

@evghenimelnic

Copy link
Copy Markdown
Owner

Summary

  • switch the static client to Babel Standalone 7 via CDN so modern JSX/ESNext features compile correctly in the browser
  • restore optional chaining usage in the notification card now that Babel handles it
  • document the Babel runtime alongside the rest of the frontend stack in the README

Testing

  • python -m compileall app

https://chatgpt.com/codex/tasks/task_e_68e2dc54ec58832eac05775e82694a53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread app/main.py
Comment on lines +34 to +39
app = FastAPI(title="Async Chat Platform")

app.add_middleware(
CORSMiddleware,
allow_origins=settings.allowed_origins,
allow_credentials=True,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge CORS defaults prevent the server from starting

The FastAPI app registers CORSMiddleware with allow_credentials=True but settings.allowed_origins defaults to ['*'] (see Settings.allowed_origins). Starlette raises ValueError: Cannot use allow_credentials=True with allow_origins=['*'] for this combination, so the application crashes on startup unless the environment variable is overridden. Provide explicit origins or disable credentials when using the wildcard to avoid a boot‑time failure.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant