Skip to content

fix(forge): zero-change tasks -> nochange, not false done/gate=ok (task 7894af1c) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eveselove merged 1 commit into from
Jun 20, 2026
Merged

fix(forge): zero-change tasks -> nochange, not false done/gate=ok (task 7894af1c) #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion forge_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,11 +726,13 @@ def detect_auth_failure(task_id, exit_code, duration, local_log=None):
"rejected": "REJ",
"reclaimed": "RECL",
"unclaimable": "UNCL",
"nochange": "NOCH",
}

TERMINAL_GOOD = {"done", "review"}
TERMINAL_BAD = {"failed", "timeout", "gatefail", "gate_timeout", "rate_limited",
"blocked", "auth", "rejected", "reclaimed", "unclaimable"}
"blocked", "auth", "rejected", "reclaimed", "unclaimable",
"nochange"}
TERMINAL = TERMINAL_GOOD | TERMINAL_BAD


Expand Down
18 changes: 16 additions & 2 deletions forge_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,24 @@ def _execute_task_inner(manifest, batch_id, repo, base_ref, gate_profile,
return

# --- SUCCESS path: COMMIT, then GATE ---
commit_sha = _commit_work(worktree_dir, task_id, title)
commit_sha, has_changes = _commit_work(worktree_dir, task_id, title)
files, add, rem = F.numstat(repo, base_ref, forge_branch)

summary = F.extract_summary(task_id) or _synth_summary(files, add, rem)

# Zero-change detection: agent exited 0 but produced no diff. The empty
# commit is kept for diffability, but we must NOT report a clean done/gate=ok
# for what is effectively a no-op (or silently-failed) agent run.
if not has_changes:
update_node(batch_id, task_id, status="nochange",
duration_s=round(duration, 1), commit_sha=commit_sha,
files_changed_count=0, lines_added=0, lines_removed=0,
summary=summary or "agent produced no file changes")
reconcile_gateway(task_id, "failed",
f"forge: no file changes (model={model}, {int(duration)}s)",
duration, agent_id)
return

update_node(batch_id, task_id, status="review", duration_s=round(duration, 1),
commit_sha=commit_sha, files_changed_count=files,
lines_added=add, lines_removed=rem, summary=summary)
Expand Down Expand Up @@ -385,7 +398,8 @@ def _commit_work(worktree_dir, task_id, title):
msg = f"forge {F.truncate(title,55)}\n\n{trailer}"
F.git(worktree_dir, *base_args, "-m", msg)
rc, sha, _ = F.git(worktree_dir, "rev-parse", "HEAD")
return sha.strip() if rc == 0 else ""
has_changes = bool(out.strip())
return (sha.strip() if rc == 0 else "", has_changes)


def _synth_summary(files, add, rem):
Expand Down
Loading