fix(hooks): pre-commit rust checks from rust/ (unblocks forge .rs commits) + rustdoc lints (task 7894af1c)#12
Merged
Conversation
…ints link pre-commit ran `cargo fmt`/`cargo clippy` from the repo root, which has no Cargo.toml (workspace is in rust/) -> `cargo metadata` error -> commit rejected. This silently blocked forge from committing ANY .rs work: forge `_commit_work` calls git with check=False, so the rejection was swallowed and the task was falsely marked done/gate=ok with an empty commit (0 files). Run the rust checks in a `( cd rust && ... )` subshell so they work in worktrees too. Also fixes the rustdoc `unresolved link to lints` warning in agentforge-long-horizon ([lints] -> `lints`) — the dogfood task that exposed the hook bug. task 7894af1c Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOGFOOD FINDING: forge could not commit any .rs work. pre-commit ran cargo from repo root (no Cargo.toml) -> commit rejected -> forge swallowed it (check=False) -> false done/gate=ok with empty commit. Fix: run rust checks via (cd rust && ...). Also fixes the rustdoc lints unresolved-link warning (the task that surfaced it). task 7894af1c