refactor(candidates): store-level skills dir, no global env in tests (task 7894af1c)#11
Merged
Merged
Conversation
…ote tests Produced by forge (agy/Opus, batch bf_ee47c549 / task-b3a2dbdc); salvaged from the worktree after the agy run hit a model-response timeout before forge committed. CandidateStore now carries an optional skills dir (with_skills_dir); promote resolves it via the store instead of reading AGENTFORGE_SKILLS_DIR directly. Copy-tests pass a per-test temp skills dir and no longer mutate the process-global env, removing the --test-threads=2 race and the real-skills pollution. Production behavior unchanged (env override + home_agentforge default still honored). Verified: cargo test --workspace --lib -- --test-threads=2 passes WITHOUT AGENTFORGE_SKILLS_DIR and writes nothing into ~/agentforge/skills; clippy + fmt clean. task 7894af1c Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged from forge agy/Opus run (batch bf_ee47c549). CandidateStore.with_skills_dir(); promote resolves skills via store; copy-tests use per-test temp dir, no global AGENTFORGE_SKILLS_DIR set_var (kills --test-threads=2 race + real-skills pollution). Prod behavior unchanged. Verified workspace --lib --test-threads=2 green without the env. task 7894af1c