Enable partial cardIcons overrides#916
Open
jmorgadosoares wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Providing a partial
cardIconsoverride (e.g. only overridingvisa) caused a TypeScript error because theiconsprop was typed as the fullCardIconstype, making all card brand keys required.Fixes [EXP-993](https://linear.app/evervault/issue/EXP-993/enable-partial-cardicons-overrides-on-js-and-react-sdks).
How
Changed the
iconsprop type toPartial<CardIcons>in the three public-facing locations:CardOptionsinpackages/types/uiComponents.ts(JS SDKui.cardconfig)CardComponentOptionsinpackages/ui-components/src/Card/types.tsCardPropsinpackages/react/lib/ui/Card.tsx(React SDK)The
collectIconsutility inutilities.tswas also updated to acceptPartial<CardIcons>and continues to spread the fullICONSdefaults first, so any unspecified brands fall back to their defaults.BrandIconkeeps itsiconsprop typed as the fullCardIconssince it is an internal component that only ever receives the already-merged result ofcollectIcons.