Migrate Catalog (Categories/Services/Tags) to Result errors; remove Services; physical reorg

[evertonschuster]

Summary

Split out of #69 (part 3 — see that PR for the full picture). Stacked on #71 (Auth + shared Result/error infra) — this PR's base branch is #71's, so its diff here shows only what this PR adds on top.

This PR is larger than the <100-file target the other three PRs in this stack hit — deliberately, see "Why this couldn't be split further" below.

• Categories, Services, and Tags all move to the Result-based error convention docs/adr/014 establishes: domain entities' create() methods, mappers, and API repositories return Result<T, AppError> instead of throwing; useAsync.ts (already Result-based, landed in Migrate Auth to Result-based error handling; add shared Result/error infra #71) is the one hook every feature's data layer builds on now.
• app/composition/container.ts's CatalogFacade drops the use-case-class indirection (ListCategories/CreateTag/etc. as separate classes) for direct repository delegation ({ execute: repo.method }) — there's no orchestration between the facade and the repository, so the extra class per operation wasn't earning its keep. The 24 now-orphaned use-case-class files (application/use-cases/{categories,services,tags}/) are deleted.
• Services' frontend implementation (ServicesPage, ServiceForm, six ServicesPage.*.test.tsx files, all its components/hooks/models) is fully removed, reverting /services to a placeholder page (app/pages/ServicesPage/ServicesPage.tsx) — this vertical goes back to stub status, see docs/STATUS.md.
• Categories moves to a routed create/edit dialog (features/catalog/presentation/categories/pages/CategoriesListPage/, .../CategoryEditorDialog/) per docs/adr/012, replacing the old flat CategoriesPage.tsx/useCategories.ts/CategoryEditorDialog.tsx shape.
• Tags gets the equivalent internal move (hooks/useTagEditor.ts, pages/TagEditorDialog.tsx) and its own Result migration (Tag.ts/tagMapper.ts/ApiTagRepository.ts) — Tags itself is not being removed here, just migrated; its removal is the next PR in this stack (docs/adr/016).
• shared/: AuthenticatedHttpClient's get/post/put/delete now return Result<T, AppError> instead of throwing; DeleteConfirmationDialog takes entityName/entityType instead of a raw title/description pair; useCreateInline is removed (no longer used once Services — its only consumer — is gone).
• Also removes .husky/pre-commit (dangling once .lintstagedrc.json is gone) — the same removal Remove local git hooks; add GetCategoryById endpoint; backend API response/CORS infra #70 makes independently; whichever of the two PRs merges first, the other's identical deletion is a no-op.

Why this couldn't be split further

I initially tried a narrower "Category-only foundation" PR (~99 files) deferring Services/Tags. That failed a real build: app/composition/container.ts wires TagRepository with its new method signature directly (tagRepository.listAll(options) instead of the old (tenantContext, options) two-arg form) — not just a return-type change useAsync-style, but the interface itself. Making that build without also migrating TagRepository/ApiTagRepository/tagMapper/Tag.ts for real isn't a smaller wrapper shim — it's the same size of work as just finishing the migration, since there's no reduced version of an interface signature. Categories, Services, and Tags share container.ts's catalog wiring, router.tsx, and AuthenticatedHttpClient tightly enough that they're one atomic, verified-buildable unit at this layer — mirroring why Auth couldn't be split from Catalog either, just one layer down.

Test plan

• npm install + npm run build --workspace=apps/admin-frontend — green
• npm run lint --workspace=apps/admin-frontend — clean, 0 warnings
• npm run format:check --workspace=apps/admin-frontend — clean
• npm run test --workspace=apps/admin-frontend — 368/368 passing
• scripts/sync_agent_skills.py --check, scripts/check_agent_governance.py, scripts/architecture_guard.py — all pass

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 973ce092-2ee1-4817-9d35-abd1875bba2a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[evertonschuster]

Fechada automaticamente quando a branch base (#71) foi mergeada e removida. Recriada como #75 a partir do main atualizado — mesmo conteúdo, mesma justificativa de tamanho, sem mudança funcional.