fix(fetchkit): harden local file saver symlink handling#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden LocalFileSaver so base_dir saves cannot escape through symlinked parent directories or final symlink targets. Update safety tests and specs/threat model for the mitigated behavior.
Why
LocalFileSaver previously depended on lexical path checks plus check-then-write behavior. In embeddings that expose save_to_file with a filesystem-backed base directory, symlinks could redirect writes outside the intended sandbox.
How
Use Unix directory file descriptors with no-follow opens for save-time traversal and final file creation. Keep the existing non-Unix fallback checks, add final-symlink regression coverage, and document the mitigation.
Risk
Checklist