Close maintenance console acceptance gaps

[evanlow]

Summary

Follow-up closeout for #196 after PR #197 was merged.

The main implementation is already in place and Issue #196 is closed, but a final pass found two small acceptance/closeability gaps:

1. The /maintenance page existed but was not discoverable from the web UI navigation.
2. The maintenance test suite did not explicitly cover the source-failure path listed in the issue acceptance criteria.

Changes

• Adds the Maintenance link to the Monitoring dropdown via main.js so the console is discoverable from the web UI.
• Marks the Monitoring dropdown active when the current page is /maintenance.
• Adds a source-failure test verifying:
  • the report fails loudly,
  • the existing constituent file is preserved,
  • no backup is created when the source fetch fails.
• Adds a smoke assertion that the static JS registers the /maintenance link.

Testing

Please run:

pytest tests/test_maintenance.py

I could not run tests locally from this chat environment because the repository is available only through the GitHub connector.

Safety

No trading/execution paths touched. This is UI discoverability and test coverage only.

Refs #196

[Copilot]

Pull request overview

Closes the remaining acceptance gaps for the Maintenance Console introduced in #197 by making /maintenance discoverable via the existing Monitoring navbar dropdown and extending the maintenance tests to cover the source-fetch failure path (ensuring safe preservation of existing files and no backups on fetch failure).

Changes:

• Injects a “Maintenance” link into the Monitoring dropdown from web/static/js/main.js, and marks Monitoring active when browsing /maintenance.
• Adds a new test covering constituent source failure behavior (fail report, preserve existing CSV, do not create backups).
• Adds a smoke test asserting the static JS contains the /maintenance link text.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
web/static/js/main.js	Adds client-side navbar augmentation to make /maintenance discoverable and highlight Monitoring when on maintenance routes.
tests/test_maintenance.py	Adds explicit coverage for source-fetch failure safety behavior and a static-asset smoke assertion for the maintenance nav link.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.