Fix demo: lockfile drift, SOAP editor import, root-redirect funnel leak#3
Open
evangauer wants to merge 2 commits into
Open
Fix demo: lockfile drift, SOAP editor import, root-redirect funnel leak#3evangauer wants to merge 2 commits into
evangauer wants to merge 2 commits into
Conversation
Two pre-existing breakages on main (from the TipTap PR) that fail CI and Vercel:
1. pnpm-lock.yaml was missing the @tiptap/* dependencies declared in
apps/web/package.json, so 'pnpm install --frozen-lockfile' (CI + Vercel)
failed with ERR_PNPM_OUTDATED_LOCKFILE. Regenerated the lockfile.
2. records/new-soap imported '@/components/SoapNoteEditor', but the component
lived in app/components/ (the @/ alias resolves to the app root, not app/).
Moved SoapNoteEditor + SoapNoteDisplay into components/ to match the
repo convention (components/{ui,layout,common}) so the import resolves.
Verified: pnpm install --frozen-lockfile, type-check, test (119), and build
all pass for both apps.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
A visitor who came straight to demo.openvpm.com hit a 307 to the marketing site (unauthenticated root -> NEXT_PUBLIC_WWW_URL), which dead-ended anyone trying to actually try the demo. Now unauthenticated root redirects to /login, which offers one-click demo access. Removes the funnel leak on the demo subdomain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
evangauer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was failing / leaking
mainwas red on CI + Vercel, and the demo subdomain leaked visitors. Three issues, all surfacing now:apps/web/package.jsondeclares@tiptap/*butpnpm-lock.yamlnever got those entries, sopnpm install --frozen-lockfile(CI + Vercel) failed withERR_PNPM_OUTDATED_LOCKFILE.records/new-soapimports@/components/SoapNoteEditor, but the file lived inapp/components/(the@/*alias maps to the app root).tscfailed with TS2307.demo.openvpm.com/were 307-redirected to the marketing site, dead-ending anyone who came straight to the demo to try it.Fix
pnpm-lock.yaml(adds the TipTap dependency tree; lockfile-only).SoapNoteEditor+SoapNoteDisplayintocomponents/to match repo convention so the import resolves./login(one-click demo access) instead of bouncing to marketing.Verified locally
pnpm install --frozen-lockfile,pnpm type-check,pnpm test(119 passing), andpnpm build(both apps) all pass.🤖 Generated with Claude Code