Preserve per-turn trace payloads#453
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3690caad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xiaoyifan
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor
Note
Low Risk
Scoped to eval-protocol trace preprocessing when
include_payloadsis enabled; no auth or production inference path changes.Overview
When remote Fireworks traces are preprocessed to a single longest conversation row, payload mode now merges each shorter trace’s completion metadata onto the matching assistant turn instead of keeping only the final turn’s data.
The default loader’s
preprocess_fnstill runsfilter_longest_conversation, then (ifinclude_payloads) calls_merge_payloads_into_longest_row: it copies missing logprobs onto assistant messages by turn index and buildsexecution_metadata.extra["assistant_turn_payloads"]from keys likecompletion_logprobs,routing_matrices, androuting_metadata. Top-levelextraon the longest row still reflects the last completion for backward compatibility.Unit tests in
test_tracing_utils.pycover multi-turn logprobs and per-turn router replay fields.Reviewed by Cursor Bugbot for commit c3690ca. Bugbot is set up for automated code reviews on this repo. Configure here.