Skip to content

feat(types): Add QUERY to RequestMethod union #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eugef merged 2 commits into from
Jul 7, 2026
Merged

feat(types): Add QUERY to RequestMethod union #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626faf7
feat(types): Add QUERY to RequestMethod union.
RobinTail Jul 3, 2026
60645c2
fix: format.
RobinTail Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/http-mock.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { IncomingMessage, OutgoingMessage } from 'http';
export type RequestType = IncomingMessage | globalThis.Request;
export type ResponseType<ResBody = any> = OutgoingMessage | globalThis.Response | Response<ResBody>;

export type RequestMethod = 'CONNECT' | 'DELETE' | 'GET' | 'HEAD' | 'OPTIONS' | 'PATCH' | 'POST' | 'PUT' | 'TRACE';
export type RequestMethod =
| 'CONNECT'
| 'DELETE'
| 'GET'
| 'HEAD'
| 'OPTIONS'
| 'PATCH'
| 'POST'
| 'PUT'
| 'QUERY'
| 'TRACE';

export interface Params {
[key: string]: any;
Expand Down
22 changes: 21 additions & 1 deletion test/lib/http-mock.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,15 @@ import { expectAssignable, expectNotAssignable, expectNotType, expectType } from
// eslint-disable-next-line import/no-unresolved
import type { Request as ExpressRequest, Response as ExpressResponse } from 'express';

import { createMocks, createRequest, createResponse, MockRequest, MockResponse, Mocks } from '../../lib/http-mock';
import {
createMocks,
createRequest,
createResponse,
MockRequest,
MockResponse,
Mocks,
RequestMethod
} from '../../lib/http-mock';

expectType<MockRequest<ExpressRequest>>(createRequest());
expectNotType<MockRequest<NodeRequest>>(createRequest());
Expand Down Expand Up @@ -40,3 +48,15 @@ expectType<Mocks<globalThis.Request, globalThis.Response>>(createMocks<globalThi
expectType<Mocks<ExpressRequest, ExpressResponse<{ message: number }>>>(
createMocks<ExpressRequest, ExpressResponse<{ message: number }>>()
);

expectAssignable<RequestMethod>('CONNECT');
expectAssignable<RequestMethod>('DELETE');
expectAssignable<RequestMethod>('GET');
expectAssignable<RequestMethod>('HEAD');
expectAssignable<RequestMethod>('OPTIONS');
expectAssignable<RequestMethod>('PATCH');
expectAssignable<RequestMethod>('POST');
expectAssignable<RequestMethod>('PUT');
expectAssignable<RequestMethod>('QUERY');
expectAssignable<RequestMethod>('TRACE');
expectNotAssignable<RequestMethod>('WRONG');
Loading