fix: custom field types settings#16
Open
tiagorochaB wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a per-type settings panel to the custom-field create/edit form. Selecting a
field type (text, number, date, list, file) now reveals only the settings relevant
to that type, and switching types resets the type-specific values cleanly. Also
includes layout fixes so the inputs lay out on a single row without overlapping.
Closes #15
Changes
CustomFieldSettingscomponent rendering type-specific inputs: label,placeholder, mask (with help link), number/date format, list selection + render
type, list options (drag-reorderable), file formats multi-select, character
limit / decimal length steppers, and attribution type.
<Select>with a card/icon type picker incustom-field-form.tsx; type is locked when editing an existing field.TYPE_SPECIFIC_FIELDS) whilepreserving title/description/attribution; list seeds one empty option.
custom-field-schema.tswith the new optional settings fields andtheir option sets (
NUMBER_FORMATS,DATE_FORMATS,LIST_SELECTION_TYPES,LIST_RENDER_TYPES,FILE_FORMATS,ATTRIBUTION_TYPES) and max-length consts.row/column gaps and forced
w-fullon the format select so it no longer shrinkswhen a value is selected.
en-US,es-ES, andpt-BR.custom-field-form.test.tsxto cover the new behavior.Type of change
fix:)feat:)refactor:)docs:)chore:)Testing
pnpm type-checkpassespnpm lintpassespnpm testpassesScreenshots
Notes for reviewers
comments).
fix/...and the commit usesfix:, but the change adds afeature; flagging in case the squash-merge title should be adjusted.