EVM Gas Points#29
Open
SamWilsn wants to merge 3 commits into
Open
Conversation
fselmo
approved these changes
Jan 7, 2026
Carsons-Eels
approved these changes
Jan 21, 2026
Carsons-Eels
left a comment
Carsons-Eels
left a comment
Collaborator
There was a problem hiding this comment.
I think this is a good update, even if it's not ideal. It clarifies the rules sufficiently that it is worth merging on it's own. We can always continue to refine it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't understand the difference between assigning 1 and 3 points here.
Imagine a change that modifies an existing gas mechanism that affects existing tests. Under the current rules, it would be assigned one point. A new mechanism doing the same would be assigned three points.
I would argue that the distinction between a new mechanism and a modification is immaterial to the complexity of a change when it requires test modifications. As an aside, new vs. modification is a very subjective criterion.
This change is one possible solution. I don't necessarily believe it is the correct one.