consumoor: drop invalid events instead of halting the partition#861
Merged
Conversation
When no DLQ is configured, invalid (permanently unflattenable) events hit the same fail-the-message path as recoverable decode/write errors, forcing Kafka to redeliver them forever — one malformed event halts the whole partition on data that can never become storable. The route layer's own contract (route.ErrInvalidEvent) already states these events are permanently unflattenable and should be dropped rather than retried. Align rejectMessage with that contract: invalid events (like already-handled route rejections) drop and ack, tracked by the MessagesRejected metric. Recoverable failures (decode, write) still fail-fast for redelivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no DLQ is configured, invalid (permanently unflattenable) events fell into the same fail-the-message path as recoverable decode/write errors, forcing Kafka to redeliver them forever — a single malformed event halted the whole partition on data that can never become storable. This aligns rejectMessage with the route layer's own
route.ErrInvalidEventcontract ("permanently unflattenable, should be dropped rather than retried"): invalid events now drop and ack like route rejections, tracked by the MessagesRejected metric, while recoverable decode/write failures still fail-fast for redelivery. Companion to the route-validation work in #860 that surfaces these invalid events.