Update EIP-8141: allow arbitrary signature data to avoid circular dependency for custom verifiers#11837
Draft
lightclient wants to merge 1 commit into
Draft
Update EIP-8141: allow arbitrary signature data to avoid circular dependency for custom verifiers#11837lightclient wants to merge 1 commit into
lightclient wants to merge 1 commit into
Conversation
…or custom verifiers
github-actions
Bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
eth-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally intended for this to be in #11481, but at the last minute somehow convinced myself it was unneeded. We realized it is actually required if we want to allow custom verifiers to be able to use the canonical signing hash. I have re-added it here, plus a few tweaks to original idea.