ci: drop lockfile-agnostic Next.js cache restore-key - #704
Merged
Conversation
The broad nextjs-${{ runner.os }}- fallback let a lockfile change
restore a .next/cache built against a different dependency graph.
After #699 bumped @types/node, the mismatched cache broke Turbopack's
internal font module resolution and reddened main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/node) merged:pnpm buildfailed withModule not found: Can't resolve '@vercel/turbopack-next/internal/font/google/font'.Restore Next.js incremental cachestep'srestore-keyshad a lockfile-agnostic fallback (nextjs-${{ runner.os }}-). When the lockfile-hash-scoped key missed (lockfile changed), it fell back to restoring any.next/cachefor the OS, including one built against an incompatible dependency graph (a different@types/node-qualifiednextpeer instance). Turbopack then failed to resolve its own internal virtual font module against the mismatched cache..next/cacheinstead of restoring a possibly-incompatible one.pnpm install --frozen-lockfile+ a cleanpnpm build(no stale cache) succeeds fine on the current lockfile — confirming the dependency bump itself is safe and the stale cache was the actual cause.Test plan
pnpm buildsucceeds with a cold.next/cacheon the current lockfile.Buildjob goes green on this PR.