Skip to content

Upgrade goal_runner to work with z3 version 4.8.7#5

Open
maciej-bendkowski wants to merge 1 commit into
eth-sri:masterfrom
maciej-bendkowski:upgrade-z3-4.8.7
Open

Upgrade goal_runner to work with z3 version 4.8.7#5
maciej-bendkowski wants to merge 1 commit into
eth-sri:masterfrom
maciej-bendkowski:upgrade-z3-4.8.7

Conversation

@maciej-bendkowski

Copy link
Copy Markdown

The current pull request upgrades the goal_runner to support z3 version 4.8.7. Essentially, it uses z3's new API to parse SMT files, cf. Z3Prover/z3#2798. In addition, it proposes two lesser changes:

  • it uses the lowercase name of the fasttext library,
  • it adds #!/bin/sh to the run_test.sh script.

Please let me know if there's anything else I should be upgrading.

@ghost

ghost commented Sep 28, 2020

Copy link
Copy Markdown

DeepCode's analysis on #1608cf found:

  • ⚠️ 2 warnings 👇

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: 🔧 Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev

Copy link
Copy Markdown

DeepCode's analysis on #1608cf found:

  • ⚠️ 2 warnings 👇

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: 🔧 Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant