raft: fix TLA+ specification to match unapplied config guard#458
raft: fix TLA+ specification to match unapplied config guard#458CharlieQiu2017 wants to merge 1 commit into
Conversation
Signed-off-by: Longfei Qiu <longfeiqiu2012@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CharlieQiu2017 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @CharlieQiu2017. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
cc @joshuazh-x |
As described in issue #456, the current TLA+ model of this Raft implementation is subtly broken due to a missing guard condition for leader campaigns. In the actual implementation, a follower or pre-candidate needs to check that there are no unapplied committed reconfig entries in its local log before initiating a campaign, but this check is not enforced in the model, leading to a potential safety violation. This PR fixes the issue by adding the guard condition. Running the driver spec in #456 against the updated TLA+ model shows that the safety violation is avoided.