Skip to content

raft: return error for rejected conf change#453

Open
NasitSony wants to merge 1 commit into
etcd-io:mainfrom
NasitSony:confchange-rejected-error
Open

raft: return error for rejected conf change#453
NasitSony wants to merge 1 commit into
etcd-io:mainfrom
NasitSony:confchange-rejected-error

Conversation

@NasitSony

Copy link
Copy Markdown

Summary

Return an explicit error when a configuration change proposal is rejected by validation and converted to a no-op entry.

Motivation

Currently, rejected configuration changes are silently converted to EntryNormal entries and Step returns nil. This makes it difficult for callers to detect that a configuration change was rejected and take corrective action.

This change preserves the existing no-op conversion behavior while returning an explicit error to notify the caller.

Testing

  • Extended TestStepIgnoreConfig to verify the returned error.
  • Updated interaction test expectations.
  • Ran go test ./....

Fixes #354

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NasitSony
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown

Hi @NasitSony. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfChange silently converted to no-op without error notification

2 participants