raft: return error for rejected conf change#453
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NasitSony The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @NasitSony. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Return an explicit error when a configuration change proposal is rejected by validation and converted to a no-op entry.
Motivation
Currently, rejected configuration changes are silently converted to
EntryNormalentries andStepreturnsnil. This makes it difficult for callers to detect that a configuration change was rejected and take corrective action.This change preserves the existing no-op conversion behavior while returning an explicit error to notify the caller.
Testing
TestStepIgnoreConfigto verify the returned error.go test ./....Fixes #354