Improve allocation for SoftState in Ready.#13
Merged
Conversation
b3762e3 to
b1546fe
Compare
Signed-off-by: Kezhi Xiong <august.xkz@gmail.com>
b1546fe to
228ee70
Compare
Contributor
|
Thank you! I rebased your PR, there were merge conflicts due to #8. Re-ran the benchmarks produced different numbers now, but the reduction we're targeting is still there. Looks like #8 (or something else) gave us an extra allocation. Not this PR's problem, though. |
tbg
approved these changes
Jan 4, 2023
Contributor
|
Thank you! |
Qian-Cheng-nju
pushed a commit
to specula-org/raft
that referenced
this pull request
Mar 26, 2026
The heartbeat loop invokes leaderSendAEs without holding cm.mu, so in the mean-time this node may have become a follower, and shouldn't be sending heartbeats. For etcd-io#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: etcd-io/raft#10.
Improve allocation for
SoftStateinReadyso that only when changes, it will escape to the heap.BenchmarkRawNoderesult (generated by benchdiff):