Skip to content

Upgrade antithesis SDK in tests#22045

Open
nwnt wants to merge 1 commit into
etcd-io:mainfrom
nwnt:upgrade-antithesis-sdk
Open

Upgrade antithesis SDK in tests#22045
nwnt wants to merge 1 commit into
etcd-io:mainfrom
nwnt:upgrade-antithesis-sdk

Conversation

@nwnt

@nwnt nwnt commented Jul 5, 2026

Copy link
Copy Markdown
Member

SDK to v0.7.2
instrumentor to latest

Built in local successfully.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nwnt

nwnt commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@serathius

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.76%. Comparing base (b9ba05c) to head (8768e73).

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22045      +/-   ##
==========================================
+ Coverage   69.66%   69.76%   +0.09%     
==========================================
  Files         449      449              
  Lines       38177    38177              
==========================================
+ Hits        26596    26633      +37     
+ Misses      10149    10122      -27     
+ Partials     1432     1422      -10     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ba05c...8768e73. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrybear327

Copy link
Copy Markdown
Contributor

/retest

Comment thread tests/antithesis/server/Dockerfile Outdated
RUN go get github.com/antithesishq/antithesis-sdk-go@v0.4.4
RUN go install github.com/antithesishq/antithesis-sdk-go/tools/antithesis-go-instrumentor@a802e8810442e01d16b3e9df77d7ce3875e36e55 # v0.4.3
RUN go get github.com/antithesishq/antithesis-sdk-go@v0.7.2
RUN go install github.com/antithesishq/antithesis-sdk-go/tools/antithesis-go-instrumentor@latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set concreate version.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done. Somehow I couldn't build with the instrumentor@v0.7.2 in my local before, but now I can.

SDK to v0.7.2
instrumentor to latest

Signed-off-by: Nont <9658731+nwnt@users.noreply.github.com>
@nwnt nwnt force-pushed the upgrade-antithesis-sdk branch from 33f7c68 to 8768e73 Compare July 6, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants