CHANGELOG: add entries for PR 22008#22014
Conversation
|
Hi @vivekpatani. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - Bump github.com/prometheus/common from 0.67.5 to [0.69.0](https://github.com/etcd-io/etcd/pull/22008). | ||
| - Bump go.etcd.io/bbolt from 1.5.0-rc.0 to [v1.5.0](https://github.com/etcd-io/etcd/pull/22008). | ||
| - Bump codeberg.org/go-latex/latex from 0.1.0 to [0.3.0](https://github.com/etcd-io/etcd/pull/22008). | ||
| - Bump codeberg.org/go-fonts/liberation from 0.5.0 to [0.6.0](https://github.com/etcd-io/etcd/pull/22008). |
There was a problem hiding this comment.
We don't need to add changelog for each dep bump.
Normally we only add changelog for golang bumps and deps bump for CVEs.
There was a problem hiding this comment.
My understanding was to add Changelog as suggested by you here: #22008 (review), was unsure, what that meant. Closing out the PR then?
There was a problem hiding this comment.
Sorry for the confusion.
The comment is mainly to mention only bbolt v1.5.0 and raft v3.7.0. Please only keep these two items.
There was a problem hiding this comment.
So supplement to my previous comment #22014 (comment), we also add changelog for the core dependencies (bbolt and raft)
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
7d84f22 to
3400724
Compare
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 26 files with indirect coverage changes @@ Coverage Diff @@
## main #22014 +/- ##
==========================================
+ Coverage 69.71% 69.76% +0.04%
==========================================
Files 449 449
Lines 38177 38177
==========================================
+ Hits 26614 26633 +19
+ Misses 10134 10122 -12
+ Partials 1429 1422 -7 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/retest |
|
@vivekpatani: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, vivekpatani The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#22008