Skip to content

Pin govulncheck to v1.3.0 to resolve the pull-etcd-govulncheck failure#21990

Merged
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260622_govuln
Jun 22, 2026
Merged

Pin govulncheck to v1.3.0 to resolve the pull-etcd-govulncheck failure#21990
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260622_govuln

Conversation

@ahrtr

@ahrtr ahrtr commented Jun 22, 2026

Copy link
Copy Markdown
Member

govulncheck's latest version v1.4.0 introduces a regression, which is causing pull-etcd-govulncheck failure. So pin the version to v1.3.0 to resolve this.

See discussion in #21959

@ahrtr ahrtr changed the title Pin govulncheck to v1.3.0 to resolve the failure Pin govulncheck to v1.3.0 to resolve the pull-etcd-govulncheck failure Jun 22, 2026
@ahrtr ahrtr force-pushed the 20260622_govuln branch from 8b62af0 to a615daf Compare June 22, 2026 10:21
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the 20260622_govuln branch from a615daf to 6e05d4d Compare June 22, 2026 10:38
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.72%. Comparing base (61d518f) to head (6e05d4d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21990      +/-   ##
==========================================
+ Coverage   69.65%   69.72%   +0.06%     
==========================================
  Files         449      449              
  Lines       38163    38163              
==========================================
+ Hits        26583    26609      +26     
+ Misses      10149    10125      -24     
+ Partials     1431     1429       -2     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d518f...6e05d4d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr

ahrtr commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/retest

@ahrtr

ahrtr commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@fuweid @ivanvc @serathius

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fuweid

fuweid commented Jun 22, 2026

Copy link
Copy Markdown
Member

/retest

@ahrtr ahrtr merged commit cd6cbac into etcd-io:main Jun 22, 2026
33 checks passed
@vivekpatani

Copy link
Copy Markdown
Contributor

@ahrtr can help with back ports, sorry it took me a bit to get to submitting this, thank you for doing that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants