Skip to content

raft: clarify conditions in unstable.stableTo#14720

Merged
tbg merged 1 commit into
etcd-io:mainfrom
nvb:nvanbenschoten/clarifyUnstableStableTo
Nov 11, 2022
Merged

raft: clarify conditions in unstable.stableTo#14720
tbg merged 1 commit into
etcd-io:mainfrom
nvb:nvanbenschoten/clarifyUnstableStableTo

Conversation

@nvb

@nvb nvb commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

No change in behavior, but clarify interaction with unstable snapshot.

Extracted from #14627. cc. @tbg

Signed-off-by: Nathan VanBenschoten nvanbenschoten@gmail.com

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

No change in behavior, but clarify interaction with unstable snapshot.

Signed-off-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@codecov-commenter

codecov-commenter commented Nov 10, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.48%. Comparing base (0bff3ad) to head (c18d79d).
⚠️ Report is 5840 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14720      +/-   ##
==========================================
- Coverage   75.63%   75.48%   -0.16%     
==========================================
  Files         457      457              
  Lines       37323    37324       +1     
==========================================
- Hits        28230    28173      -57     
- Misses       7327     7377      +50     
- Partials     1766     1774       +8     
Flag Coverage Δ
all 75.48% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr ahrtr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbg tbg merged commit 910b81b into etcd-io:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants