Move account and help menus to side nav footer#1988
Open
GregorShear wants to merge 1 commit into
Open
Conversation
Relocate UserMenu (account/avatar) and HelpMenu from the top app bar to the lower-left of the side navigation. Their popups now open upward and drop the downward-pointing arrow to suit the new bottom-docked position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
TopBar.tsx: removeUserMenuandHelpMenufrom the app bar.Navigation.tsx: renderUserMenuandHelpMenuin the sidebar footer list.UserMenu.tsx/HelpMenu.tsx: open the popup upward and hide the arrow.Test plan
npm run typechecknpm run lint(changed files)