Skip to content

Improve Docker daemon error for flowctl runtime#2976

Open
RitwijParmar wants to merge 1 commit into
estuary:masterfrom
RitwijParmar:codex/estuary-docker-daemon-error
Open

Improve Docker daemon error for flowctl runtime#2976
RitwijParmar wants to merge 1 commit into
estuary:masterfrom
RitwijParmar:codex/estuary-docker-daemon-error

Conversation

@RitwijParmar
Copy link
Copy Markdown

Summary

  • detect Docker daemon/connectivity errors even when the docker CLI exits successfully with the real failure on stderr
  • return a clear flowctl-oriented error before empty docker inspect output reaches JSON parsing
  • apply the fix to both runtime and runtime-next container paths with focused unit coverage

Fixes #2969.

Tests

  • cargo fmt --check
  • cargo test -p runtime detects_docker_daemon_unavailable_from_stderr --lib
  • cargo test -p runtime ignores_unrelated_docker_stderr --lib
  • cargo test -p runtime-next detects_docker_daemon_unavailable_from_stderr --lib
  • cargo test -p runtime-next ignores_unrelated_docker_stderr --lib
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flowctl: clearer error when Docker daemon isn't running

1 participant