protocols/catalog: skip NULL-spec rows in LoadAll* queries#2959
Open
SeanWhelan wants to merge 2 commits into
Open
protocols/catalog: skip NULL-spec rows in LoadAll* queries#2959SeanWhelan wants to merge 2 commits into
SeanWhelan wants to merge 2 commits into
Conversation
jgraettinger
approved these changes
May 27, 2026
Member
jgraettinger
left a comment
There was a problem hiding this comment.
LGTM
As a nit, LLMs tend to overly-extend comments to document the conditions of a change, including discussion of historical conditions that are no longer true, or handling which is obvious just by reading the code itself. In this case, I would have left the function comments as they are, and just added the WHERE guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
flowctl catalog delete --name <test>(and any publication that deletes a test) currently fails with:The Rust build layer represents a deletion as a
built_*row withspecNULL (perBuiltRow::is_deletein built.rs). The Go-sideLoadAll*queries in build_load.go did not filter those rows, soflowctl-go api testwouldScana NULLspecinto an empty byte slice,Unmarshalit into a zero-valueTestSpec, and tripTestSpec.Validate()withmissing Name.Fix: add
WHERE spec IS NOT NULLto all four LoadAll* queries (collections, captures, materializations, tests). The same defect was latent in the other three loaders even though the visible failure was only in tests, since the test phase is the one that per-row-validates inside loadSpecs.Workflow steps:
Repo before fix:
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)