fix(libjpeg-turbo): wire SBOM manifest and correct CPE#766
Open
fhrbata wants to merge 1 commit into
Open
Conversation
sbom_libjpeg.yml was never referenced from idf_component.yml, so esp-idf-sbom never discovered it. The component was therefore left out of SBOM generation and CVE scanning, and the manifest was never validated. Add the sbom section so the manifest is picked up. With the manifest now validated, correct the CPE, which was both malformed (CPE-spec-version field "3.1.1" instead of "2.3") and pointed at the wrong product (libjpeg, i.e. IJG libjpeg). Replace it with the two products NVD assigns to libjpeg-turbo CVEs: libjpeg-turbo:libjpeg-turbo and d.r.commander:libjpeg-turbo. Bump the component revision accordingly. Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
libjpeg-turbo/sbom_libjpeg.ymlwas never referenced fromlibjpeg-turbo/idf_component.yml.esp-idf-sbomonly treats a file as a manifest if it is wired through one of its recognized entry points (sbom.yml,idf_component.yml,.gitmodules), so the unreferencedsbom_libjpeg.ymlwas invisible to it. As a resultlibjpeg-turbowas excluded from SBOM generation and CVE scanning, and its manifest was never validated by thetest_sbomCI job.This PR:
sbom:section toidf_component.yml(matching every other component here), sosbom_libjpeg.ymlis discovered.3.1.1instead of2.3, so the value was not a well-formed CPE 2.3 binding and never matched NVD; andlibjpeg:libjpegis IJG libjpeg, not libjpeg-turbo. Replaced with the two products NVD assigns to libjpeg-turbo CVEs:libjpeg-turbo:libjpeg-turboandd.r.commander:libjpeg-turbo(both, since NVD splits libjpeg-turbo CVEs across the two vendors).3.1.1~2.With the manifest wired in,
esp-idf-sbom manifest validatediscovers and validates it (exit 0).