Skip to content

Revert "ci: Temporarily disable S31 device examples builds"#469

Merged
igi540 merged 2 commits into
masterfrom
ci/reenable_s31_device
Apr 19, 2026
Merged

Revert "ci: Temporarily disable S31 device examples builds"#469
igi540 merged 2 commits into
masterfrom
ci/reenable_s31_device

Conversation

@tore-espressif

@tore-espressif tore-espressif commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit c45edde and eb6597a

Related


Note

Medium Risk
Re-enables CI builds for esp32s31 USB device examples, which may reintroduce previously failing builds if support is still incomplete.

Overview
Removes the temporary CI disablement for esp32s31 USB device examples by deleting the esp32s31 rule from .idf-build-examples-rules.yml.

Updates the USB test-app workflow to stop passing esp32s31 in idf-build-apps --disable-targets, allowing esp32s31 builds to run again.

Reviewed by Cursor Bugbot for commit 53c4b0e. Bugbot is set up for automated code reviews on this repo. Configure here.

@tore-espressif tore-espressif self-assigned this Apr 13, 2026
@tore-espressif tore-espressif added the CI CI related PR label Apr 13, 2026
@peter-marcisovsky

Copy link
Copy Markdown
Collaborator

FYI, you can disable the examples build the same way as I did in the same workflow here

Base automatically changed from release/usb_host_uvc_2.5.0 to master April 14, 2026 04:43
@tore-espressif

Copy link
Copy Markdown
Collaborator Author

FYI, you can disable the examples build the same way as I did in the same workflow here

@peter-marcisovsky ah, sorry, I already merged #460 before reading this comment...

@tore-espressif tore-espressif force-pushed the ci/reenable_s31_device branch from 859ea75 to 53c4b0e Compare April 14, 2026 11:28
@tore-espressif tore-espressif added BUILD_AND_TEST_IDF_EXAMPLES Build and run esp-idf usb host and device examples in PR BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. labels Apr 14, 2026
@tore-espressif tore-espressif marked this pull request as ready for review April 17, 2026 16:05
@igi540 igi540 merged commit d118b12 into master Apr 19, 2026
61 checks passed
@igi540 igi540 deleted the ci/reenable_s31_device branch April 19, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. BUILD_AND_TEST_IDF_EXAMPLES Build and run esp-idf usb host and device examples in PR CI CI related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants