Skip to content

feat: add board M5Stack Tab5(ST7123).#80

Open
TinyuZhao wants to merge 1 commit into
espressif:masterfrom
TinyuZhao:master
Open

feat: add board M5Stack Tab5(ST7123).#80
TinyuZhao wants to merge 1 commit into
espressif:masterfrom
TinyuZhao:master

Conversation

@TinyuZhao

Copy link
Copy Markdown
Contributor

Description

This PR adds board support for M5Stack Tab5(ST7123) under application/edge_agent/boards/m5stack/m5stack_tab5.

Summary of changes:

  • Extend Tab5 board support to detect the panel type at runtime instead of assuming a single display stack.
  • Add runtime selection between:
    • ILI9881C + GT911
    • ST7123 + ST7123 touch
  • Add ST7123-specific display initialization commands.
  • Update Tab5 display/touch factory logic to:
    • probe panel ID
    • apply variant-specific panel timing
    • instantiate the matching LCD driver
    • instantiate the matching touch driver

This board support also handles two known Tab5 display variants at runtime:

  • ILI9881C + GT911
  • ST7123 + ST7123 touch

Testing

Attempted local validation with the following commands:

idf.py -C application/edge_agent gen-bmgr-config -c ./boards -b m5stack_tab5
idf.py -C application/edge_agent flash monitor

Current status:

  • Board manager generation for m5stack_tab5 succeeds.
  • Firmware boots on Tab5 hardware.
  • Runtime panel detection succeeds.
  • ST7123 variant was detected and initialized successfully during local bring-up.
  • LCD display and touch were both initialized successfully on tested hardware.
  • Board manager completed initialization and provisioning AP started successfully.

Notes:

  • Validation was performed on available Tab5 hardware during bring-up.
  • This PR includes runtime handling for both known Tab5 display/touch variants, but local confirmation depends on hardware availability.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Signed-off-by: Tinyu <tinyu0806@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant