Skip to content

Update torch support#2

Merged
Fhrozen merged 7 commits into
mainfrom
pr-torch
Apr 4, 2026
Merged

Update torch support#2
Fhrozen merged 7 commits into
mainfrom
pr-torch

Conversation

@Fhrozen
Copy link
Copy Markdown
Member

@Fhrozen Fhrozen commented Apr 4, 2026

This pull request updates the GitHub Actions CI workflows to support newer versions of torchaudio and expands the workflow triggers to run on all branches, not just main. The changes also update the Python version matrix and simplify the configuration.

Workflow trigger updates:

  • Both .github/workflows/ci.yml and .github/workflows/espnet.yml now trigger on pushes to any branch, not just main, in addition to pull requests. [1] [2]

Dependency and matrix updates:

  • The torchaudio-version matrix in both workflows is updated to test only recent versions: 2.5.1, 2.7.1, 2.8.0, and 2.9.1, removing older versions. [1] [2]
  • The Python version matrix now explicitly includes Python 3.12 with the latest torchaudio version (2.9.1). [1] [2]
  • The include section is simplified to only add the Python 3.12 and torchaudio 2.9.1 combination. [1] [2]

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Apr 4, 2026
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 4, 2026
@Fhrozen
Copy link
Copy Markdown
Member Author

Fhrozen commented Apr 4, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's dependencies, specifically bumping torch and torchaudio to version 2.5.1 and removing legacy audio backend configurations and unused imports. However, the tox.ini file includes several non-existent torchaudio versions (2.7.1, 2.8.0, and 2.9.1) which will cause environment setup failures.

Comment thread tox.ini
# content of: tox.ini , put in same dir as setup.py
[tox]
envlist = common_upstream-py310-audio2.1.2,
envlist = common_upstream-py311-audio2.9.1,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The default environment audio2.9.1 refers to a version of torchaudio that does not exist on PyPI. This will cause tox to fail by default. Based on current PyTorch releases, the latest stable version is 2.5.1.

envlist = common_upstream-py311-audio2.5.1,

Comment thread tox.ini
Comment on lines +16 to +18
audio2.7.1: {envpython} -m pip install torchaudio==2.7.1
audio2.8.0: {envpython} -m pip install torchaudio==2.8.0
audio2.9.1: {envpython} -m pip install torchaudio==2.9.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The torchaudio versions 2.7.1, 2.8.0, and 2.9.1 are not available on PyPI. torchaudio versions typically track torch versions, which are currently at 2.5.x. Specifying these non-existent versions will cause CI failures. Please use valid versions such as 2.2.2, 2.3.1, 2.4.1, or 2.5.1.

@Fhrozen Fhrozen merged commit 572af70 into main Apr 4, 2026
11 checks passed
@Fhrozen Fhrozen deleted the pr-torch branch April 4, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant