Add conventional-comments package for espanso#205
Conversation
smeech
left a comment
smeech
left a comment
There was a problem hiding this comment.
A simple single trigger, making use of anchors and aliases.
No script/shell or potentially malicious code.
I've made a few "nitpick" comments beyond the "homepage:` requirement!
| description: A simple package to show how to create your own one! | ||
| version: 0.1.0 | ||
| author: Lucas Bonanni | ||
| tags: ["conventional comments", "github"] |
There was a problem hiding this comment.
Would you kindly add a homepage: key and value, please? We've had difficulty merging some packages without it.
homepage: https://github.com/lucasbonanni/hub/tree/main would do, although you may have a broader homepage of your own.
| @@ -0,0 +1,30 @@ | |||
| # Conventional Comments Match Configuration | |||
| # Inspired by https://conventionalcomments.org/ | |||
| variables: | |||
There was a problem hiding this comment.
For consistency with the docs, would you name this section anchors:, please?
|
|
||
| matches: | ||
| - trigger: ":ccc" | ||
| form: '[[label]] ([[decorations]]): ' |
There was a problem hiding this comment.
The use of decorations for both a variable and an anchor/alias name is a little confusing. labels/label is marginally better.
Would you mind using, for example, decorations_list and labels_list, for the anchors/aliases?
| decorations: | ||
| type: choice | ||
| values: *decorations | ||
| description: "Single line comment format // Comment" |
|
Hi @lucasbonanni, are you planning to fix the issues with this PR, or shall I close it? We can always reopen it later. With best wishes. |
|
Hi @smeech! Yes, please keep it open. I'm planning to address the feedback as soon as I can. Thanks for taking the time to review it! |
2 participants
Inspired by the Conventional Comments project.