Adjustments to default widget colors from Tcl::pTk#52
Open
chrstphrchvz wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I have pushed another commit which was done in Tcl::pTk to avoid similar issues with DialogBox and Balloon widgets. |
chrstphrchvz
force-pushed
the
derived-no-colors
branch
from
fe76589 to
a809db2
Compare
chrstphrchvz
changed the title
As done in Tcl::pTk 1.00.
As done in Tcl::pTk 1.01: - Balloon.pm: set default foreground to 'black' - DialogBox.pm: do not set default foreground color
chrstphrchvz
force-pushed
the
derived-no-colors
branch
from
a809db2 to
4d71dff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change that I made in Tcl::pTk 1.00 to resolve a few issues on macOS Aqua: RT #125049, RT #129505.
This change does seem to not affect appearance at all in X11 or Windows, and likewise I do not observe any differences when applied to Perl/Tk, but I am providing this for consistency, as well as to verify if this change is appropriate or if it introduces any issues that I'm not yet aware of.