feat(followers): TicketFollower entity + add_follower handler#78
Merged
Conversation
Spring had add_follower whitelisted in WorkflowEngine.ACTION_TYPES but unhandled (the dispatch switch hit the default warn-log), with no followers table. - TicketFollower JPA entity + TicketFollowerRepository. - Flyway migration V10: escalated_ticket_followers table. - FollowerRecipients.resolve() (exclude actor + dedup, unit tested). - WorkflowExecutorService now handles add_follower (idempotently records the follower), with handler tests. Spring resolves no follower recipients in its own notifications, so followers are recorded and the resolved recipients exposed for the host to deliver to. Closes #74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Problem
add_followerwas whitelisted inWorkflowEngine.ACTION_TYPESbut unhandled —WorkflowExecutorService's dispatch switch hit the default warn-log, with no followers table.Change
TicketFollower(JPA) +TicketFollowerRepository.escalated_ticket_followers(ticket_id/user_id, unique; user_id VARCHAR for flexible host keys).FollowerRecipients.resolve()(exclude actor + dedup, unit tested).WorkflowExecutorServicenow idempotently records a follower foradd_follower, with handler tests.Design note
Spring's notifications resolve no follower recipients of their own, so the package records followers and exposes the resolved recipients for the host to deliver to.
Verification
Local:
./gradlew test checkstyleMain checkstyleTestBUILD SUCCESSFUL (3 new tests; checkstyle warnings are all pre-existing files).