feat(plugins): hide upload control on the admin Plugins page#98
Merged
Conversation
Escalated plugins here are compiled host modules registered in config, not uploaded ZIPs, so the shared admin Plugins page's upload flow does not apply. Pass can_upload: false to the Inertia page (the shared page defaults it to true for Laravel, whose plugins are uploaded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with escalated#126. The shared admin Plugins page now takes a
can_uploadprop (defaulttrue). Escalated-Phoenix plugins are compiled host modules registered in config — there is no ZIP-upload endpoint — so the controller passescan_upload: false, which hides the Upload button and switches the empty-state copy to "Register a plugin in the host application…".One-line prop addition to
PluginController.index/2; no logic change.Verification
CI runs the authoritative gate (
mix format --check-formatted+mix credo --stricton changed files +mix test). The change is a single map-key addition to an existing multi-line Inertia render call, format-clean and within the 98-col limit.