feat(followers): ticket followers + add_follower handler + CI tests#95
Merged
Conversation
…tests Phoenix had add_follower whitelisted in @action_types but unhandled (fell through to :unknown), with no followers table. - Migration: escalated_ticket_followers table. - Escalated.Schemas.TicketFollower schema + changeset. - Escalated.Services.Followers context: follower_recipients/2 (exclude actor + dedup, unit tested), add_follower/2, follower_user_ids/2. - WorkflowExecutor now handles add_follower (records the follower). - New `mix test` CI job — previously CI only ran format + credo. Phoenix has no reply/status notification fan-out of its own, so followers are recorded and the resolved recipients are exposed for the host to deliver to. Closes #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
Problem
add_followerwas whitelisted in@action_typesbut unhandled (fell through to{:error, type, :unknown}), with no followers table.Change
escalated_ticket_followers(ticket_id/user_id, unique).Escalated.Schemas.TicketFollower+ changeset.Escalated.Services.Followers:follower_recipients/2(exclude actor + dedup, unit tested),add_follower/2,follower_user_ids/2.WorkflowExecutornow dispatchesadd_follower(records the follower) instead of:unknown.mix testjob — previously CI ran only format + credo.Design note
Like the Go port, Phoenix has no reply/status notification fan-out of its own, so the package records followers and exposes the resolved recipients (
follower_user_ids/2) for the host to deliver to, rather than emitting on an event.