feat(followers): TicketFollower entity + add_follower handler#99
Merged
Conversation
.NET had add_follower whitelisted in WorkflowEngine.ActionTypes but unhandled (the dispatch switch hit the default warn-log), with no followers table. - TicketFollower model + DbSet + EF Core configuration (unique index). - Migration: escalated_ticket_followers table (multi-provider: Npgsql/SqlServer/Sqlite). - FollowerRecipients.Resolve() (exclude actor + dedup, unit tested). - WorkflowExecutorService now handles add_follower (idempotently records the follower). .NET's notification sender is a no-op by design, so followers are recorded and the resolved recipients exposed for the host to deliver to. The snapshot is config-derived (EscalatedModelConfiguration.Configure), so it picks up the new entity automatically — no snapshot edit needed. Closes #92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
Problem
add_followerwas whitelisted inWorkflowEngine.ActionTypesbut unhandled —WorkflowExecutorService.DispatchAsynchit the default warn-log, with no followers table.Change
TicketFollower+DbSet+ EF Core config (unique index on TicketId/UserId).escalated_ticket_followers(multi-provider, hand-written to match the repo's clean style).FollowerRecipients.Resolve()(exclude actor + dedup, unit tested).WorkflowExecutorServicenow idempotently records a follower foradd_follower.Notes
IEscalatedNotificationSenderis a no-op by design, so the package records followers and exposes the resolved recipients for the host to deliver to.EscalatedModelConfiguration.Configure), so adding the entity to that config updates the snapshot automatically — no snapshot file edit.Verification
Local: 346 tests pass (incl. 2 new),
dotnet buildclean,dotnet formatclean on changed files.