Add app-wide configuration values provider endpoint#487
Merged
Conversation
Documents the plan to adopt adaptive navigation (NavigationSuiteScaffold + adaptive-navigation3 list-detail), MaterialExpressiveTheme with the expressive motion scheme, and Expressive components on the value-editor screens. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Enum option lists can be long, so use a proper scrollable selectable list instead of ToggleButtonGroup, gated behind a dogfooded boolean feature toggle (read via toggles-flow) so the new behavior can be tested at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Task-by-task plan covering adaptive navigation, list-detail pane, expressive components on the value editors, and the toggle-gated enum list, derived from the approved design spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Returns all configuration values for the calling application in a single query (configurationValuesUri), the foundational read primitive for a client-side in-memory replica. Additive; no existing endpoint changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new, purely-additive provider read endpoint —
TogglesProviderContract.configurationValuesUri()— that returns all configuration values for the calling application in a single query, instead of requiring a separate query per configuration.configurationValues, distinct from theconfiguration/*key matcher) + recorded in the hand-maintainedtoggles-core.api.ProviderConfigurationDao.getConfigurationValueCursor(callingApplication)Room query — the existing per-config values query minus theconfigurationIdfilter (scoped toapplicationId).UriMatch.CONFIGURATION_VALUESmatcher entry plus thequery()andgetType()branches inTogglesProvider. The new query inherits the sharedsetNotificationUri, so the cursor notifies on changes.This is the foundational read primitive for a planned client-side in-memory replica (build the full toggle snapshot from three wholesale reads — scopes, configurations, all values — instead of 3 queries per flag). It targets a measured ~240-round-trip cost on a 40-flag Compose settings screen.
Test Plan
TogglesProviderAllConfigurationValuesTest): getType mime, values across configurations, values across scopes (with content assertions), empty cursor:toggles-coreand:modules:provider:implementationjavap -publicconfirms the public signature matches the.apientry./gradlew check+ instrumentation tests🤖 Generated with Claude Code