Harden .gitattributes: force LF for shell scripts#1152
Merged
Conversation
The repo's .gitattributes already normalizes text (`* text=auto eol=crlf`) and the tree is already normalized (`git add --renormalize .` is a no-op). Gap: with the global eol=crlf rule, a future *.sh would be checked out CRLF and fail under Git Bash, which this repo uses heavily. Add `*.sh text eol=lf`. No tracked .sh files today, so this changes nothing now — it's a latent-footgun guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance follow-up to the EOL-hygiene item. Finding: the repo already has a
.gitattributes(* text=auto eol=crlf+ binary markers) and the tree is already normalized (git add --renormalize .is a no-op) — so the CRLF/LF mix is resolved.One gap closed here: the global
eol=crlfrule would check out a future*.shas CRLF, which fails under Git Bash (this repo uses it heavily). Added*.sh text eol=lf. No tracked.shfiles today, so this changes nothing now — it's a latent-footgun guard.🤖 Generated with Claude Code