#1141: per-event cards keep forensic detail + numeric Current Value (gotqn feedback)#1146
Merged
Merged
Conversation
…tqn feedback) Addresses gotqn's two findings from testing the dev build (the #1140 fingerprint itself tested great — stable key + climbing Occurrences): 1. Per-event cards no longer carry LESS detail than Summary. AlertIncident now carries transient DetailFields (forensic facts), populated by the groupers from the representative event: blocking -> Database / Contentious Object / Blocked Query / Blocking Query / Lock Mode; deadlock -> Victim SQL / Processes (Lite), Query / Wait Resource / Lock Mode (Dashboard). PerEventNotification.Split renders them onto each per-incident card and now also carries the source AttachmentXml/FileName so per-event email keeps the deadlock_graph.xml / blocked_process_report.xml. Summary rendering is untouched (AlertIncidentRenderer.Apply leaves DetailFields off to avoid duplicating the builder's own items), and DetailFields are not persisted. 2. Per-event "Current Value" is now the occurrence count (a number, matching Summary), not the involved-objects string (which already shows as its own fact). Lite 500 + Dashboard 487 tests green (3 new: detail preserved, attachment carried, Current Value = count); both apps build 0 warnings. Refs #1141 #1140 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two things gotqn found while testing the dev build (the #1140 fingerprint tested great — stable key + climbing Occurrences; these are per-event delivery polish):
PerEventNotification.Splitbuilt a fresh context with only the dedup metadata, dropping the builder's per-incident detail (deadlock Victim SQL/Processes; blocking Database/Query/Lock Mode) and the email'sdeadlock_graph.xmlattachment. Now:AlertIncidentcarries transientDetailFields(forensic facts), populated by the groupers from the representative event.Splitrenders them onto each per-incident card and carries the sourceAttachmentXml/AttachmentFileName.AlertIncidentRenderer.ApplyomitsDetailFieldsto avoid duplicating the builder's own items);DetailFieldsaren't persisted.Verification
Keeps this on #1141 (no separate issue needed, per gotqn's offer).
🤖 Generated with Claude Code