Allow flymake-ruff to use Ruff config files from remote TRAMP hosts#24
Open
struan-robertson wants to merge 6 commits into
Open
Allow flymake-ruff to use Ruff config files from remote TRAMP hosts#24struan-robertson wants to merge 6 commits into
struan-robertson wants to merge 6 commits into
Conversation
Don't pollute /tmp Fix error on directory existing Cache config and use tramp-handle-* funcitons to stop TRAMP reentrant errors
struan-robertson
force-pushed
the
master
branch
from
560b471 to
e880aa6
Compare
Owner
|
Hi, thanks for your contribution, I'll have to do some tests before merging this |
struan-robertson
force-pushed
the
master
branch
from
b72ddb1 to
d4905ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flymake-ruffuses a local Ruff executable when checking a remote TRAMP file, which is preferable as the code checked is confined to the buffer and running commands over TRAMP can be slow. However,flymake-rufftries to pass the full TRAMP path (i.e./ssh:remote:/path/to/pyproject.toml) to Ruff as the config file location. This pull request copies the remote config file to/tmpon the local machine so that it can be passed to the Ruff executable. To stop TRAMP slowing to a crawl and prevent reentrant errors, the config is cached in tmp and can be refreshed by reverting the buffer.