Skip to content

Work/vibe it up#13

Merged
erenken merged 19 commits into
mainfrom
work/vibeItUp
Jul 9, 2026
Merged

Work/vibe it up#13
erenken merged 19 commits into
mainfrom
work/vibeItUp

Conversation

@erenken

@erenken erenken commented Jul 9, 2026

Copy link
Copy Markdown
Owner

This pull request introduces comprehensive documentation, configuration, and workflow improvements to the GateMonitor repository, focusing on clarifying project architecture, agent responsibilities, and build/release automation for both the Angular and .NET stacks. It adds detailed agent and architectural instructions, modernizes CI/CD pipelines, and enhances developer tooling for a clearer and more maintainable development process.

Documentation and Architecture Guidance

  • Added detailed Copilot and agent instructions for both the Angular and .NET subprojects, specifying architecture boundaries, coding practices, testing expectations, and agent selection criteria. This includes new markdown files such as .github/copilot-instructions.md, .github/agents/gatemonitor-specialist.agent.md, .github/agents/dotnet-specialist.agent.md, .github/instructions/gatemonitor-architecture.instructions.md, and .github/instructions/dotnet-architecture.instructions.md. [1] [2] [3] [4] [5]

  • Introduced prompt files for Copilot agents to handle UI work, troubleshooting, and library changes in a structured way, ensuring consistent output and process for contributors. [1] [2] [3]

CI/CD Pipeline Enhancements

  • Replaced legacy workflows with unified, modern GitHub Actions for build, test, packaging, and release of both the Angular and .NET projects. The new .github/workflows/dotnet-build.yml and .github/workflows/dotnet-release.yml automate versioning, NuGet/NPM publishing, and tagging, while removing the old .github/workflows/remootio-angular-deploy.yml. [1] [2] [3]

Developer Tooling Improvements

  • Updated .vscode/launch.json to provide clear launch configurations for both Angular and Blazor development and test workflows, and .vscode/tasks.json to ensure Angular tasks run in the correct working directory. [1] [2]

These changes collectively establish clear project boundaries, streamline development and release processes, and provide actionable guidance for contributors working across the Angular and .NET stacks.


References:

erenken added 5 commits July 8, 2026 21:12
…chitecture boundaries, copilot instructions, and troubleshooting guidelines
- Add dotnet/ subtree: Blazor WASM app, myNOC.Remootio .NET library (NuGet-ready), Aspire AppHost, and MSTest/bUnit test projects
- Implement Remootio WebSocket protocol, crypto, and gate state events in .NET
- Add unified CI/CD: PR build/test, NuGet/NPM publish, GitHub release/tag
- Add architecture/agent instructions and update .gitignore for .NET/Angular/Aspire/secrets
- Update documentation for both Angular and .NET stacks
- Add Blazor layouts, navigation, gate UI, and CSS
- Add comprehensive unit/component tests for .NET and Blazor
- Add MIT license for .NET library
- Add @types/crypto-js to Angular devDependencies for type safety
- Remove legacy remootio-angular-deploy.yml workflow
Introduces pr-build-test.yml GitHub Actions workflow to automate build and test for both .NET and Angular projects. The workflow runs on PRs, pushes to main, and manual triggers, with separate jobs for .NET and Angular, and a final status check to ensure all jobs pass.
- Upgraded Angular from 15 to 22
- Added agent files and instructions
- Removed deprecated Angular files (polyfills, test.ts, environment.prod)
- Kept updated copilot-instructions.md for dual-stack architecture
- Updated README.md to reference Angular 22 instead of 15
- Updated Angular CLI installation instructions for folder structure
- Created angular/README.md with Angular 22 upgrade notes
- Updated .github/copilot-instructions.md with Angular 22 version
- Updated CI workflow reference to pr-build-test.yml
- Added angular/README.md to documentation list
Comment thread .github/workflows/dotnet-build.yml Fixed
Comment thread .github/workflows/dotnet-build.yml Fixed
Comment thread .github/workflows/dotnet-build.yml Fixed
Comment thread .github/workflows/pr-build-test.yml Fixed
Comment thread .github/workflows/pr-build-test.yml Fixed
Comment thread .github/workflows/pr-build-test.yml Fixed
erenken and others added 4 commits July 9, 2026 00:36
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Workflow fixes:
- Merged duplicate permissions sections
- Made test reporter non-blocking and PR-only
- Updated Node.js from 18 to 20 for Angular 22 compatibility
- Added continue-on-error for test reporter to prevent spurious failures

Added:
- .github/BRANCH_PROTECTION.md with setup instructions
erenken and others added 2 commits July 9, 2026 00:49
- Added fetch-depth: 0 to both checkout actions
- This fetches full git history required by GitVersion
- Fixes error: 'Repository is a shallow clone. Git repositories must contain the full history'

See: https://gitversion.net/docs/reference/requirements#unshallow
erenken added 3 commits July 9, 2026 00:52
Ensures full Git history is available in deploy-dotnet, deploy-angular, and tag jobs by configuring actions/checkout@v4 with fetch-depth: 0. This supports versioning, changelog generation, and tagging operations that require complete commit history.
Updated the Node.js version from 20 to 24 in both dotnet-build.yml and dotnet-release.yml GitHub Actions workflows. This ensures Angular dependencies are installed and built using the latest Node.js LTS version.
pr-build-test.yml:
- Added step to build remootio-angular library before main app
- Ensures library is compiled before app that depends on it

dotnet-build.yml:
- Added fetch-depth: 0 to all checkout actions for GitVersion

Fixes build order: library -> app -> tests
erenken and others added 5 commits July 9, 2026 01:05
- Added mock RemootioAngularService with spy objects
- Provides gateState\$ observable and isAuthenticated property
- Fixes test failure: missing required service dependency

HomeComponent requires RemootioAngularService in constructor,
test was failing because TestBed didn't provide it.
HomeComponent test fix:
- Added MatCardModule and MatButtonModule imports
- Added CommonModule for Angular directives (*ngIf, async pipe)
- Template uses mat-card and mat-fab which need these modules

Keep Node 24 for latest features and compatibility.

Fixes test failures in GitHub Actions
Added MatDividerModule to FooterComponent and AppComponent specs to support Material divider usage. Declared FooterComponent in AppComponent spec and HomeComponent in its own spec for proper test setup. Cleaned up and aligned TestBed configurations for more robust testing.
- Fixed TS1117 error: duplicate 'declarations' key
- TestBed.configureTestingModule now has clean config
- Keeps Material modules and service mock intact
@erenken erenken merged commit 2422bbf into main Jul 9, 2026
9 checks passed
@erenken erenken deleted the work/vibeItUp branch July 9, 2026 05:21
Copilot stopped work on behalf of erenken due to an error July 9, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants