Several fixes for compilation, dialyzer, documentation and "make options"#1
Merged
Merged
Conversation
badlop
changed the title
erebion
force-pushed
the
add_unified_push_module
branch
from
d194bc2 to
2e0594c
Compare
Owner
|
@badlop I've re-based this branch as requested, this created merge conflicts. I'm not sure how to solve them correctly as I don't understand the code. |
Author
|
Your branch seems to be correctly rebased. I've updated my branch and this PR too, and now seems to be correctly rebased too. And seems to pass the tests in my repository :) If you click on the run tests button here, let's see if it passes all tests for sure. |
Owner
Done! Shall I merge now? Any more changes? |
Author
Yes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.