Add gather_summary_observations cli command#13625
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13625 +/- ##
==========================================
- Coverage 89.57% 89.21% -0.37%
==========================================
Files 466 469 +3
Lines 32962 33257 +295
==========================================
+ Hits 29526 29670 +144
- Misses 3436 3587 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9af1dfa to
2e078e8
Compare
There was a problem hiding this comment.
Pull request overview
Adds an experimental gather_summary_observations CLI command for extracting summary observations from ERT storage into a CSV file.
Changes:
- Adds the new CLI command behind
ERT_FEATURE_GATHER_OBS. - Implements summary-key parsing, storage API startup/access, experiment selection, and CSV export.
- Adds UI tests for feature-flag behavior, CSV generation, and interactive experiment selection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/ert/__main__.py |
Registers the experimental gather_summary_observations subcommand. |
src/ert/gather_summary_observations.py |
Implements API startup, observation extraction, summary-key conversion, and CSV output. |
src/ert/services/_storage_main.py |
Logs the served storage directory for API startup discovery. |
tests/ert/ui_tests/cli/test_gather_sumary_observations.py |
Adds CLI tests for the new command. |
eivindjahren
left a comment
There was a problem hiding this comment.
There is a couple of things we should probably fix up a little bit before we merge, but other than that there is no need to delay too much as this is behind a featureflag.
b26d668 to
8704133
Compare
|
I am planning on squashing this into a single commit. |
To enable distance based localization, this command will help gather well names from summary keys to streamline an automated collection of well metadata.
On macos there is an issue with the dns where the storage stores two potential urls for the storage api, where only one works. This change will ping all listed urls and select the first one with a 200 response.
We try to avoid that dependency
Also includes small fixups in code
461fde0 to
6200c69
Compare
0d76105 to
f93952d
Compare
aaa4855 to
d589bea
Compare
Also added error handling
d589bea to
d63e3d2
Compare
No description provided.