Skip to content

Support ES-MDA weights from config#13553

Draft
dafeda wants to merge 1 commit into
equinor:mainfrom
dafeda:es-mda-weights
Draft

Support ES-MDA weights from config#13553
dafeda wants to merge 1 commit into
equinor:mainfrom
dafeda:es-mda-weights

Conversation

@dafeda
Copy link
Copy Markdown
Collaborator

@dafeda dafeda commented May 13, 2026

Allow UPDATE_ALGORITHM ES_MDA WEIGHTS to define default ES-MDA weights for CLI and GUI runs, while preserving explicit CLI/GUI overrides.

Issue
Resolves #13540

Adding this to config:

UPDATE_ALGORITHM ES_MDA WEIGHTS 1, 1, 1

Gives this on start:

image

Changing weights in GUI gives a warning:

image

Closing ert, changing weights in config and re-opening ert uses the new weights:

Question: should this throw a warning?

image
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

Allow UPDATE_ALGORITHM ES_MDA WEIGHTS to define default ES-MDA weights for CLI and GUI runs,
while preserving explicit CLI/GUI overrides.
@dafeda dafeda self-assigned this May 13, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2026

Codecov Report

❌ Patch coverage is 91.76471% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (8d253e0) to head (2c9e468).

Files with missing lines Patch % Lines
...ui/experiments/multiple_data_assimilation_panel.py 91.11% 4 Missing ⚠️
src/ert/config/analysis_config.py 90.90% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13553   +/-   ##
=======================================
  Coverage   89.63%   89.64%           
=======================================
  Files         460      460           
  Lines       32519    32582   +63     
=======================================
+ Hits        29150    29208   +58     
- Misses       3369     3374    +5     
Flag Coverage Δ
cli-tests 36.97% <30.58%> (-0.05%) ⬇️
fuzz 43.92% <17.64%> (-0.05%) ⬇️
gui-tests 63.73% <78.82%> (+0.02%) ⬆️
performance-and-unit-tests 78.07% <89.41%> (+0.02%) ⬆️
test 45.57% <14.11%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/__main__.py 87.50% <ø> (-0.05%) ⬇️
src/ert/config/parsing/config_keywords.py 100.00% <100.00%> (ø)
src/ert/config/parsing/config_schema.py 100.00% <100.00%> (ø)
src/ert/run_models/model_factory.py 97.69% <ø> (ø)
src/ert/run_models/multiple_data_assimilation.py 93.93% <100.00%> (+0.13%) ⬆️
src/ert/config/analysis_config.py 96.55% <90.90%> (-1.67%) ⬇️
...ui/experiments/multiple_data_assimilation_panel.py 93.91% <91.11%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 13, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing dafeda:es-mda-weights (2c9e468) with main (8d253e0)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying ES_MDA weights in the ERT config file

2 participants