Support ES-MDA weights from config#13553
Draft
dafeda wants to merge 1 commit into
Draft
Conversation
Allow UPDATE_ALGORITHM ES_MDA WEIGHTS to define default ES-MDA weights for CLI and GUI runs, while preserving explicit CLI/GUI overrides.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13553 +/- ##
=======================================
Coverage 89.63% 89.64%
=======================================
Files 460 460
Lines 32519 32582 +63
=======================================
+ Hits 29150 29208 +58
- Misses 3369 3374 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow UPDATE_ALGORITHM ES_MDA WEIGHTS to define default ES-MDA weights for CLI and GUI runs, while preserving explicit CLI/GUI overrides.
Issue
Resolves #13540
Adding this to config:
UPDATE_ALGORITHM ES_MDA WEIGHTS 1, 1, 1Gives this on start:
Changing weights in GUI gives a warning:
Closing ert, changing weights in config and re-opening ert uses the new weights:
Question: should this throw a warning?
git rebase -i main --exec 'just rapid-tests')When applicable