Add extra=forbid to pydantic basemodel in ResponseConfig, tests fix a…#13511
Open
erlenlh wants to merge 1 commit into
Open
Add extra=forbid to pydantic basemodel in ResponseConfig, tests fix a…#13511erlenlh wants to merge 1 commit into
erlenlh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13511 +/- ##
========================================
Coverage 89.95% 89.95%
========================================
Files 459 460 +1
Lines 32173 32409 +236
========================================
+ Hits 28942 29155 +213
- Misses 3231 3254 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xjules
reviewed
May 21, 2026
| Path("CASE.SMSPEC").write_bytes(smspec) | ||
| with suppress(InvalidResponseFile): | ||
| SummaryConfig( | ||
| name="summary", input_files=["CASE"], keys=["FOPR"] |
Contributor
There was a problem hiding this comment.
hm, interesting. Maybe this could be a case for a migration?
Contributor
There was a problem hiding this comment.
Update: I guess it depends if name is only "summary" or it can refer to something else too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd cleanup
Issue
Resolves #13510
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable