Skip to content

Refactor server ert#13452

Open
oyvindeide wants to merge 11 commits into
equinor:mainfrom
oyvindeide:refactor_server_ert
Open

Refactor server ert#13452
oyvindeide wants to merge 11 commits into
equinor:mainfrom
oyvindeide:refactor_server_ert

Conversation

@oyvindeide
Copy link
Copy Markdown
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@oyvindeide oyvindeide force-pushed the refactor_server_ert branch from 0229b84 to 5d457fe Compare May 4, 2026 10:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2026

Codecov Report

❌ Patch coverage is 40.69767% with 153 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.39%. Comparing base (15b1b96) to head (e1f2d46).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/ert/dark_storage/endpoints/experiment_server.py 26.73% 74 Missing ⚠️
src/ert/gui/experiments/experiment_panel.py 10.52% 51 Missing ⚠️
src/ert/gui/experiments/experiment_client.py 40.00% 21 Missing ⚠️
src/ert/run_models/model_factory.py 86.11% 5 Missing ⚠️
src/ert/run_models/ensemble_smoother.py 75.00% 1 Missing ⚠️
src/everest/gui/main_window.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (15b1b96) and HEAD (e1f2d46). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (15b1b96) HEAD (e1f2d46)
gui-tests 5 0
test 5 4
performance-and-unit-tests 5 0
cli-tests 5 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13452       +/-   ##
===========================================
- Coverage   89.96%   56.39%   -33.57%     
===========================================
  Files         460      460               
  Lines       32409    32555      +146     
===========================================
- Hits        29158    18361    -10797     
- Misses       3251    14194    +10943     
Flag Coverage Δ
cli-tests 36.39% <20.54%> (-0.66%) ⬇️
fuzz 44.06% <29.06%> (+0.03%) ⬆️
gui-tests ?
performance-and-unit-tests ?
test 47.70% <38.37%> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/run_models/ensemble_experiment.py 97.67% <100.00%> (-2.33%) ⬇️
src/ert/run_models/ensemble_information_filter.py 96.00% <100.00%> (-4.00%) ⬇️
src/ert/run_models/evaluate_ensemble.py 59.52% <100.00%> (-35.60%) ⬇️
src/ert/run_models/manual_update.py 61.90% <100.00%> (-33.22%) ⬇️
src/ert/run_models/manual_update_enif.py 84.21% <100.00%> (-9.54%) ⬇️
src/ert/run_models/multiple_data_assimilation.py 89.47% <100.00%> (-4.34%) ⬇️
src/ert/run_models/single_test_run.py 91.66% <100.00%> (-8.34%) ⬇️
src/everest/config/everest_config.py 94.48% <100.00%> (+0.02%) ⬆️
src/everest/strings.py 100.00% <100.00%> (ø)
src/ert/run_models/ensemble_smoother.py 95.12% <75.00%> (-2.32%) ⬇️
... and 5 more

... and 270 files with indirect coverage changes

@oyvindeide oyvindeide force-pushed the refactor_server_ert branch 2 times, most recently from c5d47c6 to 63e19e8 Compare May 4, 2026 14:00
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 4, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing oyvindeide:refactor_server_ert (78ea7ed) with main (d5f13f9)

Open in CodSpeed

@oyvindeide oyvindeide force-pushed the refactor_server_ert branch 5 times, most recently from e63dc14 to 15d6458 Compare May 8, 2026 12:20
oyvindeide added 10 commits May 8, 2026 15:34
To align everest and ert, we would like to execute all run
models through the experiment server, and not have to gui own the
run model like it does today. This pr allows the experiment_server
to run all run models, and not just the everest run model.
@oyvindeide oyvindeide force-pushed the refactor_server_ert branch from 15d6458 to 5a2163c Compare May 8, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants