Skip to content

WIP: 3D heat-equation#13349

Open
dafeda wants to merge 1 commit into
equinor:mainfrom
dafeda:rho-matrix-broadcasting
Open

WIP: 3D heat-equation#13349
dafeda wants to merge 1 commit into
equinor:mainfrom
dafeda:rho-matrix-broadcasting

Conversation

@dafeda
Copy link
Copy Markdown
Collaborator

@dafeda dafeda commented Apr 20, 2026

Using np.tile

image image image

Using np.repeat

image image
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@dafeda dafeda requested a review from larsevj April 20, 2026 07:39
@dafeda dafeda self-assigned this Apr 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (8036c93) to head (57108c3).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13349      +/-   ##
==========================================
- Coverage   90.04%   90.02%   -0.03%     
==========================================
  Files         457      457              
  Lines       31735    31739       +4     
==========================================
- Hits        28576    28572       -4     
- Misses       3159     3167       +8     
Flag Coverage Δ
cli-tests 37.51% <100.00%> (+<0.01%) ⬆️
fuzz 44.38% <0.00%> (-0.01%) ⬇️
gui-tests 67.03% <0.00%> (-0.03%) ⬇️
performance-and-unit-tests 77.96% <0.00%> (-0.02%) ⬇️
test 46.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/analysis/_update_strategies/_distance.py 74.68% <100.00%> (+0.99%) ⬆️

... and 4 files with indirect coverage changes

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing dafeda:rho-matrix-broadcasting (57108c3) with main (c6c7312)

Open in CodSpeed

@dafeda dafeda force-pushed the rho-matrix-broadcasting branch 2 times, most recently from 198ce0f to 57108c3 Compare April 20, 2026 11:44
@dafeda dafeda force-pushed the rho-matrix-broadcasting branch from 57108c3 to 64da4cf Compare April 21, 2026 08:42
@dafeda dafeda changed the title Replace np.tile with np.broadcast_to for rho z-layer tiling WIP: 3D heat-equation Apr 21, 2026
cond = sample_prior_conductivity(
ensemble_size=1, nx=nx, rng=rng, corr_length=corr_lengths[i]
ensemble_size=1, nx=nx, nz=nz, rng=rng, corr_length=corr_lengths[i]
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a .reshape(nx, nx, nz) here compared to code in heat_equation.py ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants