Skip to content

stream_handlers customizable#32

Open
IciaCarroBarallobre wants to merge 2 commits into
eproxus:mainfrom
IciaCarroBarallobre:iciac/customizable-stream-handlers
Open

stream_handlers customizable#32
IciaCarroBarallobre wants to merge 2 commits into
eproxus:mainfrom
IciaCarroBarallobre:iciac/customizable-stream-handlers

Conversation

@IciaCarroBarallobre

Copy link
Copy Markdown

Hi,

Would it be possible to make the stream_handlers configurable?

This would make it much easier to integrate OpenTelemetry Cowboy into a project where we are using Kraft.

@eproxus

eproxus commented Oct 22, 2025

Copy link
Copy Markdown
Owner

Looks good, and thanks for adding an example! Can you make sure the type checkin passes and we can get this merged? ☺️

@IciaCarroBarallobre

IciaCarroBarallobre commented Oct 23, 2025

Copy link
Copy Markdown
Author

Should we keep extra_src_dirs? When it compiles everything as a single root application, I think it ignores the individual rebar.config files in each example, which means their specific dependencies (like telemetry) aren't loaded into the Dialyzer PLT :(

If we want to keep extra_src_dirs, we could add telemetry to Kraft's main dependencies, but that would broke Kraft's minimalist philosophy by forcing unnecessary dependencies on all users, no? >:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants