Add project-icon.svg for Collins - #34
Merged
Merged
Conversation
SVG rendition of the adaptive launcher icon (purple tile + white calendar with intensity dots), picked up by Collins as this project's sidebar icon. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGSF75haz1qsDQXq5admdR
ghackett
marked this pull request as ready for review
August 2, 2026 15:29
ghackett
enabled auto-merge (squash)
August 2, 2026 15:29
📦 Debug APK from this buildBuilt from commit Download the APK (workflow-run artifact; requires a GitHub login and expires with the run's retention window) Scan to download on a device:
|
ghackett
added a commit
that referenced
this pull request
Aug 2, 2026
## Summary Fixes the `project-icon.svg` added in #34 not actually showing up in Collins' sidebar — Collins was silently falling back to the generic folder icon. ## Root cause Collins rasterizes project icons through gdk-pixbuf's SVG loader (`GdkPixbuf.PixbufLoader.new_with_type("svg")`), and that loader only recognizes a file as SVG when the `<svg` tag appears **within the first 256 bytes** (verified empirically: padding a minimal SVG shows the loader flips from OK to `Unsupported image format` exactly when `<svg` moves from byte 257 to byte 258). Our XML declaration plus the 4-line header comment pushed the tag to byte **270**, so the loader rejected the file and Collins used its fallback icon. The original PR verified the file with `rsvg-convert`, which parses the document with a real XML parser and has no such sniff window — which is why it looked fine there. (Collins' own `project-icon.svg` also has a leading comment, but a shorter one: its `<svg` sits at byte 191.) ## Fix Move the header comment *inside* the `<svg>` element, so the tag now lands at byte 39. No change to the artwork. The comment also now documents the 256-byte constraint so it doesn't regress. ## Verification Rasterized through the exact loader path Collins uses (`PixbufLoader.new_with_type("svg")` + `set_size`) at 16px (sidebar size) and 256px — both succeed, and `collins.projecticons.project_icon_data()` still accepts the file: <img src="https://raw.githubusercontent.com/episode6/screenshots/main/headache-tracker/fix-collins-project-icon/icon-256-gdkpixbuf-20260802-113934.png" width="200" alt="project-icon.svg rendered via gdk-pixbuf at 256px after the fix" /> 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_012SHFReWXKqrmD4hBzUTT6q Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
project-icon.svgto the repo root — an SVG rendition of the app's adaptive launcher icon. Collins picks up aproject-icon.svgfrom a project's root directory and shows it in place of the generic folder icon in its sidebar.The SVG reproduces
ic_launcher_background.xml+ic_launcher_foreground.xmlfaithfully: the same purple#6200EEbackground (drawn as a rounded square), the same 0.8x safe-zone transform on the foreground, and the calendar cropped to the adaptive icon's visible 72dp region.Verified by rasterizing with librsvg (the renderer Collins uses) at 256px (above) and 16px (sidebar size).
No app/build changes — the file lives outside
app/, so the APK is untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_01SGSF75haz1qsDQXq5admdR